Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Playwright testing #10930

Merged
merged 19 commits into from
May 17, 2024
Merged

Conversation

codeKraken19
Copy link
Contributor

Notes for Reviewers

This PR fixes #
#10890

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 11, 2024
Copy link

github-actions bot commented May 11, 2024

leecalcote
leecalcote previously approved these changes May 14, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have seed resources.

@leecalcote leecalcote added area/ci Continuous Integration area/tests Testing / quality assurance labels May 14, 2024
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Umar Ali <mailtoumar014@gmail.com>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@github-actions github-actions bot added the area/docs Documentation update needed label May 16, 2024
leecalcote
leecalcote previously approved these changes May 16, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I relocated the e2e test docs into the contributing guide.

A section on Writing and Organizing Tests is needed.

Integration into GitHub Workflows is needed.

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@l5io
Copy link
Collaborator

l5io commented May 16, 2024

@aabidsofi19 aabidsofi19 changed the title Initialize Playwright testing [WIP] Initialize Playwright testing May 17, 2024
@aabidsofi19
Copy link
Contributor

@leecalcote thanks , the content of that google docs would go there .

@aabidsofi19 aabidsofi19 merged commit 459b41c into meshery:master May 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration area/docs Documentation update needed area/tests Testing / quality assurance component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants