Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement new missing permissions page #10969

Merged
merged 14 commits into from
May 17, 2024

Conversation

dragon-slayer875
Copy link
Contributor

@dragon-slayer875 dragon-slayer875 commented May 15, 2024

Notes for Reviewers

This PR fixes updates the design of the missing permissions page.

image

image

Signed commits

  • Yes, I signed my commits.

Copy link

github-actions bot commented May 15, 2024

@dragon-slayer875
Copy link
Contributor Author

After discussion with @Yashsharma1911, it was decided to put the request roles feature on hold for now as it will need some help from him, which he will provide as soon as he gets time from his exams.

Apart from that this new layout is ready to be used.

dragon-slayer875 and others added 14 commits May 16, 2024 06:23
Signed-off-by: Rudraksh Tyagi <59254790+dragon-slayer875@users.noreply.github.com>
Signed-off-by: Rudraksh Tyagi <59254790+dragon-slayer875@users.noreply.github.com>
Signed-off-by: Rudraksh Tyagi <59254790+dragon-slayer875@users.noreply.github.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
@leecalcote
Copy link
Member

After discussion with @Yashsharma1911, it was decided to put the request roles feature on hold for now as it will need some help from him, which he will provide as soon as he gets time from his exams.

Apart from that this new layout is ready to be used.

Thank you for this status update.

@leecalcote
Copy link
Member

@dragon-slayer875, you're refactoring to simply include the org switcher, right? If you can't achieve this tomorrow, then simply update the verbiage to be more friendly. This task has been outstanding for ... well, entirely too long.

@dragon-slayer875
Copy link
Contributor Author

dragon-slayer875 commented May 17, 2024

@dragon-slayer875, you're refactoring to simply include the org switcher, right? If you can't achieve this tomorrow, then simply update the verbiage to be more friendly. This task has been outstanding for ... well, entirely too long.

@leecalcote I think there's some miscommunication going on between us.
This page is functional right now.
This PR can be reviewed and following the review, if there are no changes, can be merged.

@leecalcote
Copy link
Member

@dragon-slayer875 perhaps, the stale screenshots and stale PR description are throwing us off.

@leecalcote
Copy link
Member

Provide a refreshed state of what is delivered here, please.

@leecalcote leecalcote merged commit 8544107 into meshery:master May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants