-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no footer for playground #10994
no footer for playground #10994
Conversation
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
6e6f6d9
to
9cc88f9
Compare
ui/pages/_app.js
Outdated
@@ -93,7 +93,10 @@ function isMesheryUiRestrictedAndThePageIsNotPlayground(capabilitiesRegistry) { | |||
capabilitiesRegistry?.restrictedAccess?.isMesheryUiRestricted | |||
); | |||
} | |||
|
|||
export const isMeshmapPath = (path = '') => { | |||
console.log('here', path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove this before merge?
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
<main | ||
className={classes.mainContent} | ||
style={{ | ||
padding: isMeshmapPath(path) && '0px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@captain-Akshay remove extension-specific logic.
@captain-Akshay what's the plan? |
Thanks, @captain-Akshay. #11027 resolves this item. |
Notes for Reviewers
This PR fixes #
Signed commits