Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no footer for playground #10994

Closed
wants to merge 2 commits into from

Conversation

captain-Akshay
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/ui User Interface label May 18, 2024
Copy link

github-actions bot commented May 18, 2024

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
ui/pages/_app.js Outdated
@@ -93,7 +93,10 @@ function isMesheryUiRestrictedAndThePageIsNotPlayground(capabilitiesRegistry) {
capabilitiesRegistry?.restrictedAccess?.isMesheryUiRestricted
);
}

export const isMeshmapPath = (path = '') => {
console.log('here', path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this before merge?

ui/pages/_app.js Outdated Show resolved Hide resolved
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
<main
className={classes.mainContent}
style={{
padding: isMeshmapPath(path) && '0px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captain-Akshay remove extension-specific logic.

@leecalcote
Copy link
Member

@captain-Akshay what's the plan?

@leecalcote
Copy link
Member

Thanks, @captain-Akshay. #11027 resolves this item.

@leecalcote leecalcote closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants