Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning mesheryctl start #10997

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Jougan-0
Copy link
Contributor

@Jougan-0 Jougan-0 commented May 19, 2024

Notes for Reviewers

This PR fixes #

  • Add warn command and if docker use give an error command
  • docs update for --port-forward command add a note that it is intended to work with docker only
  • Note addition to kubernetes getting started page
  • Note addition to Guides file

@leecalcote Might need to re-position this( placement of include) in dashboard.go because can be seen when using --help command couldn't figure out where to keep it . Currently under Example I am unable to understand where to place them so that it can be detected other than example and long description. The placement in docs gives error.

Signed commits

  • Yes, I signed my commits.

Jougan-0 and others added 5 commits May 17, 2024 22:36
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@github-actions github-actions bot added area/docs Documentation update needed component/mesheryctl CLI for Meshery labels May 19, 2024
Copy link

github-actions bot commented May 19, 2024

Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 19, 2024

@Jougan-0
Copy link
Contributor Author

Jougan-0 commented May 19, 2024

For mesheryctl docs update to be shown do we need to pass something else I wonder?
As it is not shown under the command but showing locally do we need to run some type of make docs under mesheryctl

@Jougan-0
Copy link
Contributor Author

https://github.com/meshery/meshery/actions/runs/9143648489/job/25140595734?pr=10997#step:7:317

this error because the old pr of json returning panic for error
meshery/meshkit#496

needs to merge .

Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@Jougan-0 Jougan-0 added the pr/do-not-merge PRs not ready to be merged label May 21, 2024
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
@leecalcote
Copy link
Member

merge conflict.

Jougan-0 and others added 2 commits May 23, 2024 19:05
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 23, 2024

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.23%. Comparing base (e5974d2) to head (85fbb4e).
Report is 17 commits behind head on master.

Files Patch % Lines
mesheryctl/internal/cli/root/system/dashboard.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10997      +/-   ##
==========================================
- Coverage    9.23%    9.23%   -0.01%     
==========================================
  Files         145      145              
  Lines       19021    19022       +1     
==========================================
  Hits         1756     1756              
- Misses      16963    16964       +1     
  Partials      302      302              
Flag Coverage Δ
unittests 9.23% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jougan-0 and others added 2 commits May 23, 2024 19:33
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 23, 2024

@leecalcote
Copy link
Member

merge conflict

Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 25, 2024

@l5io
Copy link
Collaborator

l5io commented May 25, 2024

@Jougan-0 Jougan-0 removed the pr/do-not-merge PRs not ready to be merged label Jun 11, 2024
@l5io
Copy link
Collaborator

l5io commented Jun 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants