Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] registry generate: fix logs #11035

Merged
merged 2 commits into from
May 25, 2024

Conversation

leecalcote
Copy link
Member

@leecalcote leecalcote commented May 23, 2024

Signed-off-by: Lee Calcote lee.calcote@layer5.io

fixes #11035

Does this matter?

Error: S1039: unnecessary use of fmt.Sprintf (gosimple)

If so, help, please.

If not, please disable check.

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label May 23, 2024
@leecalcote leecalcote requested a review from MUzairS15 May 23, 2024 23:34
Copy link

github-actions bot commented May 23, 2024

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jougan-0 Will you fix the usage of fmt.Sprintf?

@Jougan-0
Copy link
Contributor

@Jougan-0 Will you fix the usage of fmt.Sprintf?

Will have a look.

@leecalcote leecalcote merged commit af68351 into master May 25, 2024
9 of 11 checks passed
@leecalcote leecalcote deleted the leecalcote/mesheryctl/registry-generator branch May 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants