Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tooltips with sistent tooltips #11052

Merged
merged 3 commits into from
May 27, 2024

Conversation

dragon-slayer875
Copy link
Contributor

Notes for Reviewers

This PR replaces tooltips in meshery and meshmap.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 27, 2024
Copy link

github-actions bot commented May 27, 2024

Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
@captain-Akshay captain-Akshay marked this pull request as ready for review May 27, 2024 15:49
@leecalcote leecalcote self-requested a review May 27, 2024 20:54
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's something off with my local build of this branch.

Do light mode tooltips show as expect on your system?

Screenshot 2024-05-27 at 3 59 16 PM

@leecalcote leecalcote merged commit 470c18c into meshery:master May 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants