Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorization of Permissions #11053

Merged
merged 6 commits into from
May 30, 2024
Merged

Categorization of Permissions #11053

merged 6 commits into from
May 30, 2024

Conversation

iArchitSharma
Copy link
Contributor

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/docs Documentation update needed label May 27, 2024
@l5io
Copy link
Collaborator

l5io commented May 27, 2024

🚀 Preview for commit 3160a5a at: https://6654525ceb7d056ad45fbb15--meshery-docs-preview.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

@iArchitSharma
Copy link
Contributor Author

@dragon-slayer875 need to merge this before my next PR

@l5io
Copy link
Collaborator

l5io commented May 28, 2024

🚀 Preview for commit e7afce3 at: https://6656073c1994c558d455c60a--meshery-docs-preview.netlify.app

dragon-slayer875
dragon-slayer875 requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@dragon-slayer875 dragon-slayer875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make it so that the lengths of all table rows are equal?
image

@l5io
Copy link
Collaborator

l5io commented May 29, 2024

🚀 Preview for commit 4372046 at: https://66570ecbd0dc999bc691b790--meshery-docs-preview.netlify.app

@iArchitSharma
Table length fix
8d2d73b 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 29, 2024

🚀 Preview for commit 8d2d73b at: https://6657105aad96e09f21c0cb17--meshery-docs-preview.netlify.app

@iArchitSharma
fixed responsive
506d22a 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 29, 2024

🚀 Preview for commit 506d22a at: https://665726cf99c6bd0d83dfb838--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented May 29, 2024

🚀 Preview for commit c6a3273 at: https://66574b731d978634fc63bb31--meshery-docs-preview.netlify.app

leecalcote
leecalcote requested changes May 29, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing Key ID and CASL moniker?

@dragon-slayer875
Copy link
Contributor

Still missing Key ID and CASL moniker?

@leecalcote Archit is working on it separately from this.
Monikers and UUIDs will be added in a new PR.

@leecalcote
Copy link
Member

ok

@leecalcote leecalcote merged commit f6b7d8e into master May 30, 2024
5 checks passed
@leecalcote leecalcote deleted the permNew branch May 30, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@Yashsharma1911 Yashsharma1911 Awaiting requested review from Yashsharma1911

@dragon-slayer875 dragon-slayer875 Awaiting requested review from dragon-slayer875

Assignees
No one assigned
Labels
area/docs Documentation update needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iArchitSharma @l5io @dragon-slayer875 @leecalcote