Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Remove hardcoded registrant/host #11073

Merged
merged 1 commit into from
May 31, 2024

Conversation

MUzairS15
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
@github-actions github-actions bot added component/server area/models Models, Components, Relationships related changes labels May 31, 2024
Copy link

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.15%. Comparing base (17acf25) to head (63478b2).
Report is 81 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11073      +/-   ##
==========================================
+ Coverage    9.00%    9.15%   +0.14%     
==========================================
  Files         146      146              
  Lines       19274    19243      -31     
==========================================
+ Hits         1736     1761      +25     
+ Misses      17236    17180      -56     
  Partials      302      302              
Flag Coverage Δ
unittests 9.15% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MUzairS15 MUzairS15 requested a review from Jougan-0 May 31, 2024 12:25
@MUzairS15
Copy link
Contributor Author

// @Jougan-0 @leecalcote

@Jougan-0
Copy link
Contributor

// @Jougan-0 @leecalcote

Will update my pr accordingly.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leecalcote
Copy link
Member

@Jougan-0 good to merge?

@leecalcote leecalcote merged commit 12957ca into meshery:master May 31, 2024
17 checks passed
@Jougan-0
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/models Models, Components, Relationships related changes component/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants