-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Key ID & Monikers #11074
Add Key ID & Monikers #11074
Conversation
Signed-off-by: Archit Sharma <archit8679@gmail.com>
🚀 Preview for commit a86e6bb at: https://6659c4db043c342e370496a5--meshery-docs-preview.netlify.app |
docs/_includes/permissions.html
Outdated
|
||
.odd-row { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of providing odd-row class maybe you can use the nth-child(odd/even) selector.
It should further help in reducing the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously that was the approach but odd even does not work in our case because every even row is a hidden row, so by default table will look fully grey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would only select the third item in list, rest of the list will not be selected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nth-child(3) might work perhaps?
🚀 Preview for commit 028ffaf at: https://665c10b47c16716956c02c4e--meshery-docs-preview.netlify.app |
@iArchitSharma Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you. 😄
🚀 Preview for commit 6b1f484 at: https://665d3317003792efc90f34a0--meshery-docs-preview.netlify.app |
Signed commits