Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key ID & Monikers #11074

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Add Key ID & Monikers #11074

merged 5 commits into from
Jun 3, 2024

Conversation

iArchitSharma
Copy link
Contributor

@iArchitSharma iArchitSharma commented May 31, 2024

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Archit Sharma <archit8679@gmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label May 31, 2024
Copy link

github-actions bot commented May 31, 2024

@l5io
Copy link
Collaborator

l5io commented May 31, 2024


.odd-row {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of providing odd-row class maybe you can use the nth-child(odd/even) selector.
It should further help in reducing the code.

Copy link
Contributor Author

@iArchitSharma iArchitSharma May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously that was the approach but odd even does not work in our case because every even row is a hidden row, so by default table will look fully grey

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of even odd you can then try
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would only select the third item in list, rest of the list will not be selected

dragon-slayer875

This comment was marked as outdated.

Copy link
Contributor

@dragon-slayer875 dragon-slayer875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nth-child(3) might work perhaps?

Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented Jun 2, 2024

@vishalvivekm
Copy link
Member

@iArchitSharma Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

Copy link
Contributor

@dragon-slayer875 dragon-slayer875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. 😄

@l5io
Copy link
Collaborator

l5io commented Jun 3, 2024

@dragon-slayer875 dragon-slayer875 merged commit d21897b into meshery:master Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants