Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

us default eval query if no query is specified in rel def #11099

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

MUzairS15
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Copy link

github-actions bot commented Jun 3, 2024

@leecalcote
Copy link
Member

relationship.GetDefaultEvaluationQuery undefined (type "github.com/layer5io/meshkit/models/meshmodel/core/v1alpha2".RelationshipDefinition has no field or method GetDefaultEvaluationQuery)

@MUzairS15
Copy link
Contributor Author

relationship.GetDefaultEvaluationQuery undefined (type "github.com/layer5io/meshkit/models/meshmodel/core/v1alpha2".RelationshipDefinition has no field or method GetDefaultEvaluationQuery)

depends on mesh kit release, have some PRs in mesh kit will release the library and bump in meshery

@MUzairS15 MUzairS15 merged commit fda9e22 into meshery:master Jun 6, 2024
8 of 11 checks passed
@@ -1605,8 +1605,8 @@ github.com/layer5io/gowrk2 v0.6.1/go.mod h1:ugxQ23+HwQ8dmZYJd1LScw/TLKbdgfN6OOtg
github.com/layer5io/meshery-operator v0.7.0 h1:YXlnsx2Xy5duM+W99vts2fFV4C1KnOCytQi2fxdQTUc=
github.com/layer5io/meshery-operator v0.7.0/go.mod h1:mVMpSrvSH1zgSmcjzk+/astXV5L34NlL/PcZMH6s2IU=
github.com/layer5io/meshkit v0.2.7/go.mod h1:QvEKV8wIEOabiFlUgiu+s78GpJTsRpoRw5pgvEX077Y=
github.com/layer5io/meshkit v0.7.26 h1:IP1DUTRAoeTUqwaN7vwjFXlSLLcyiVk26pIiE2twjCM=
github.com/layer5io/meshkit v0.7.26/go.mod h1:Yvctcc5N6A208my5dME89Tl+jLMlOHtTAhjD+Yg/xzc=
github.com/layer5io/meshkit v0.7.28 h1:Vttfb4beceUfzHRjeUiY4v7XWEvZroTeFwk8j9xwpos=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is go.mod syncer not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants