Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Promote model command #11114

Merged

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Jun 5, 2024

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@github-actions github-actions bot added area/docs Documentation update needed component/mesheryctl CLI for Meshery labels Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

@l5io
Copy link
Collaborator

l5io commented Jun 5, 2024

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.24%. Comparing base (63478b2) to head (e198620).
Report is 176 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11114      +/-   ##
==========================================
+ Coverage    9.15%    9.24%   +0.09%     
==========================================
  Files         146      145       -1     
  Lines       19243    18999     -244     
==========================================
- Hits         1761     1756       -5     
+ Misses      17180    16941     -239     
  Partials      302      302              
Flag Coverage Δ
unittests 9.24% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@leecalcote leecalcote marked this pull request as ready for review June 6, 2024 20:57
@leecalcote leecalcote merged commit 157d740 into meshery:master Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants