fix: logs to have same current model and extracted model #11118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signoff Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11118 +/- ##
==========================================
- Coverage 9.15% 9.14% -0.01%
==========================================
Files 146 146
Lines 19243 19247 +4
==========================================
Hits 1761 1761
- Misses 17180 17184 +4
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MUzairS15
reviewed
Jun 5, 2024
| @@ -19,7 +19,7 @@ func ErrUpdateRegistry(err error, path string) error { | |||
| } | |||
|
|
|||
| func ErrGenerateModel(err error, modelName string) error { | |||
| return errors.New(ErrGenerateModelCode, errors.Alert, []string{fmt.Sprintf("error generating model: %s", modelName)}, []string{err.Error()}, []string{"Registrant used for the model is not supported", "Verify the model's source URL.", "Failed to create a local directory in the filesystem for this model."}, []string{"Ensure that each kind of registrant used is a supported kind.", "Ensure correct model source URL is provided and properly formatted.", "Ensure sufficient permissions to allow creation of model directory."}) | |||
| return errors.New(ErrGenerateModelCode, errors.Alert, []string{fmt.Sprintf("error generating model: %s", modelName)}, []string{fmt.Sprintf("Error generating model: %s\n %s", modelName, err.Error())}, []string{"Registrant used for the model is not supported", "Verify the model's source URL.", "Failed to create a local directory in the filesystem for this model."}, []string{"Ensure that each kind of registrant used is a supported kind.", "Ensure correct model source URL is provided and properly formatted.", "Ensure sufficient permissions to allow creation of model directory."}) | |||
There was a problem hiding this comment.
fmt.Sprintf("Error generating model: %s\n %s")
This is being repeated, it is already present in short description
There was a problem hiding this comment.
But the logging done in the RegistryGenerate file it writes only the longDescription so either we can use it to write short + long or we can just put in long and remove from short.
Thoughts?
Jougan-0
changed the title
MUzairS15
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #11117
The model name for a model whose components were failing were missing and the error couldn't be located for which model it happened so whenever error happens while generating components log the component name before the error.
Signed commits