-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relationships]: Nginx ingress relationships #11121
Merged
MUzairS15
merged 12 commits into
meshery:master
from
innocentrda:nginx-ingress-relationships
Jun 18, 2024
Merged
[Relationships]: Nginx ingress relationships #11121
MUzairS15
merged 12 commits into
meshery:master
from
innocentrda:nginx-ingress-relationships
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: innocentrda <twagirinno@gmail.com>
Signed-off-by: innocentrda <twagirinno@gmail.com>
github-actions
bot
added
component/server
area/models
Models, Components, Relationships related changes
labels
Jun 6, 2024
leecalcote
reviewed
Jun 6, 2024
"description": "A hierarchical inventory relationship in which the configuration of (parent) component is patched with the configuration of other (child) component. E.g Secret->Pod, ConfigMaps->Deployment, etc..." | ||
}, | ||
"model": { | ||
"schemaVersion": "core.meshery.io/v1beta2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there's some confusion here. While we need to upgrade to v1beta1 of the Relationships schema, you'll want to use v1alpha2 for the time being.
Signed-off-by: innocentrda <twagirinno@gmail.com>
MUzairS15
previously approved these changes
Jun 18, 2024
server/meshmodel/nginx-ingress/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
server/meshmodel/nginx-ingress/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
This PR suggests relationships between nginx ingress controller components.
The Policy resource allows you to configure features like access control and rate-limiting, which you can add to your VirtualServer and VirtualServerRoute resources. Similarly to Secret->Pod, ConfigMaps->Deployment relationships, the suggested reationship between Policy and VirtualServer and VirtualServerRoute is hierarchical inventory relationship in which the configuration of (parent) component is patched with the configuration of other (child) component.
Signed commits