Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Support performing upgrades for existing dependent resources. #11127

Merged

Conversation

MUzairS15
Copy link
Contributor

Notes for Reviewers

This PR fixes #
During provisioning of a Design, Meshery Server detects dependent CRDs/operators and tries to install them via applying Helm Chart/raw manifests, in case where the required helm chart/manifests already exists it creates a conflict and the operation fails.
The PR adds the ability to perform an upgrade if the required resources already exists.

Signed commits

  • Yes, I signed my commits.

…erator

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
@MUzairS15
Copy link
Contributor Author

Docs update in #10998

Copy link

github-actions bot commented Jun 6, 2024

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 9.14%. Comparing base (63478b2) to head (2786857).
Report is 194 commits behind head on master.

Files Patch % Lines
server/handlers/design_engine_handler.go 0.00% 5 Missing ⚠️
server/handlers/content_modifier.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11127      +/-   ##
==========================================
- Coverage    9.15%    9.14%   -0.01%     
==========================================
  Files         146      146              
  Lines       19243    19253      +10     
==========================================
  Hits         1761     1761              
- Misses      17180    17190      +10     
  Partials      302      302              
Flag Coverage Δ
unittests 9.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MUzairS15 MUzairS15 merged commit ce2e4f6 into meshery:master Jun 6, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant