-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update styles in SCSS files meshery docs #11139
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
🚀 Preview for commit 13ea0e9 at: https://6664d0c534f1033bfcd69165--meshery-docs-preview.netlify.app |
@animeshchaudhri Thank you for your contribution. |
docs/_sass/elements.scss
Outdated
& li { | ||
margin: 2px 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes here, correct?
Including any changes outside of changes material to the issue at-hand makes PR review more challenging, risky, and comes with longer merge times. If you're able to remove these changes, that would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSS was conflicting and not given priority , so I moved it down to ensure it applies correctly @leecalcote
docs/_sass/mesheryctl.scss
Outdated
@@ -24,9 +24,15 @@ div.prereqs { | |||
margin-top: 0; | |||
} | |||
color: #ddd; | |||
margin: 20px; | |||
margin: 0.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for switching to rem
.
docs/_sass/td-content.scss
Outdated
& > h4 { | ||
font-size: 1rem; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. 👍
Thank you @animeshchaudhri |
@vishalvivekm can you get this pr reviewed ? |
🚀 Preview for commit 942e678 at: https://666c4adb19c45a58ca93349b--meshery-docs-preview.netlify.app |
@animeshchaudhri Preview of these changes https://6664d0c534f1033bfcd69165--meshery-docs-preview.netlify.app/guides/infrastructure-management/overview:docs: https://docs.meshery.io/guides/infrastructure-management/overview: |
@vishalvivekm will take a look |
Thank you @animeshchaudhri, Let's discuss item on Websites call today, if you've made further progress. |
Notes for Reviewers
This PR fixes #10705
Updated styles in meshery/docs
alert.scss
,elements.scss
,mesheryctl.scss
, andtd-content.scss
to improve responsiveness and readability.h1
,h2
,h3
,h4
) intd-content.scss
for screens with a maximum width of 320px.ul
andol
elements to make them responsive inelements.scss
and added media queries .Current State
After
Signed commits