Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update styles in SCSS files meshery docs #11139

Closed
wants to merge 0 commits into from

Conversation

animeshchaudhri
Copy link
Contributor

Notes for Reviewers

This PR fixes #10705

Updated styles in meshery/docs alert.scss, elements.scss, mesheryctl.scss, and td-content.scss to improve responsiveness and readability.

  • Added media queries to adjust font sizes for headings (h1, h2, h3, h4) in td-content.scss for screens with a maximum width of 320px.
  • Adjusted styles for ul and ol elements to make them responsive in elements.scss and added media queries .

Current State

image image

After

image

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jun 8, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the area/docs Documentation update needed label Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

@l5io
Copy link
Collaborator

l5io commented Jun 8, 2024

@vishalvivekm
Copy link
Member

@animeshchaudhri Thank you for your contribution.
Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

& li {
margin: 2px 0;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes here, correct?

Including any changes outside of changes material to the issue at-hand makes PR review more challenging, risky, and comes with longer merge times. If you're able to remove these changes, that would be helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS was conflicting and not given priority , so I moved it down to ensure it applies correctly @leecalcote

@@ -24,9 +24,15 @@ div.prereqs {
margin-top: 0;
}
color: #ddd;
margin: 20px;
margin: 0.5rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for switching to rem.

& > h4 {
font-size: 1rem;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. 👍

@vishalvivekm
Copy link
Member

Thank you @animeshchaudhri
Let's discuss this in Meshery Dev meeting starting in 20 minutes.
Meeting minutes: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit?pli=1#
Meeting link: https://meet.layer5.io/meshery

@animeshchaudhri
Copy link
Contributor Author

@vishalvivekm can you get this pr reviewed ?

@l5io
Copy link
Collaborator

l5io commented Jun 14, 2024

@vishalvivekm
Copy link
Member

@animeshchaudhri
will you take a look at these picture of the same page in the preview of your PR and the live docs:

Preview of these changes https://6664d0c534f1033bfcd69165--meshery-docs-preview.netlify.app/guides/infrastructure-management/overview:

docs: https://docs.meshery.io/guides/infrastructure-management/overview:

@animeshchaudhri
Copy link
Contributor Author

@vishalvivekm will take a look

@vishalvivekm
Copy link
Member

@vishalvivekm will take a look

Thank you @animeshchaudhri, Let's discuss item on Websites call today, if you've made further progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Responsiveness issues
4 participants