-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captain/publishmodal #11140
Captain/publishmodal #11140
Conversation
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@Yashsharma1911 I do need help with making the RJSF required for publish action and not for save action |
In info modal we delete the required property from schema before passing it to RJSF, when user clicks on publish pass schema with required property and use RJSF validate, you can find implementation of how to validate in Helm Wizard in Meshery UI |
@captain-Akshay lemme know when you will push the new changes |
merge conflicts. |
Merge conflicts still. |
Is selective validation not possible? Should we close this PR? |
Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
Screenshot? |
Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
7c1b54b
to
075cf64
Compare
Notes for Reviewers
This PR fixes #
Signed commits