Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captain/publishmodal #11140

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

captain-Akshay
Copy link
Contributor

@captain-Akshay captain-Akshay commented Jun 9, 2024

Notes for Reviewers

This PR fixes #

Screenshot 2024-06-24 at 4 34 00 AM

Signed commits

  • Yes, I signed my commits.

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Jun 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

@captain-Akshay
Copy link
Contributor Author

captain-Akshay commented Jun 9, 2024

@Yashsharma1911 I do need help with making the RJSF required for publish action and not for save action

@Yashsharma1911
Copy link
Contributor

@Yashsharma1911 I do need help with making the RJSF required for publish action and not for save action

In info modal we delete the required property from schema before passing it to RJSF, when user clicks on publish pass schema with required property and use RJSF validate, you can find implementation of how to validate in Helm Wizard in Meshery UI

@Yashsharma1911
Copy link
Contributor

@Yashsharma1911 I do need help with making the RJSF required for publish action and not for save action

In info modal we delete the required property from schema before passing it to RJSF, when user clicks on publish pass schema with required property and use RJSF validate, you can find implementation of how to validate in Helm Wizard in Meshery UI

@captain-Akshay lemme know when you will push the new changes

@leecalcote
Copy link
Member

merge conflicts.

@leecalcote
Copy link
Member

Merge conflicts still.

@leecalcote
Copy link
Member

Is selective validation not possible? Should we close this PR?

Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
@leecalcote
Copy link
Member

Screenshot?

captain-Akshay added 2 commits June 24, 2024 04:33
Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshaysharma0503@gmail.com>
@leecalcote leecalcote merged commit c6b305c into meshery:master Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants