Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Schema Validation Actor to WebWorker #11141

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Move Schema Validation Actor to WebWorker #11141

merged 10 commits into from
Jun 12, 2024

Conversation

codeSafari10
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@codeSafari10
move validation to webworkers
e78dd39 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@codeSafari10
Merge branch 'master' of github.com:meshery/meshery into webworkers
1a616af
@codeSafari10
fix error
98c3ffb 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@codeSafari10
allow rjsf form to use custom errors and validtors
f05facf 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@codeSafari10
remove logs
9942d33 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Jun 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024 •
edited
Loading

leecalcote
leecalcote reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some heavy lifting happening here. 🏋️‍♂️ Excellent.

@leecalcote
Copy link
Member

There's an eslint item to have a peek at here:

/home/runner/work/meshery/meshery/ui/rtk-query/design.js
  72:7  error  'yy' is assigned a value but never used  no-unused-vars
  73:9  error  'x' is assigned a value but never used   no-unused-vars

codeSafari10 and others added 5 commits June 12, 2024 12:58
@codeSafari10
show component count format in dry run
f65e5ba 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@codeSafari10
remove dead code
7e445d2 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@codeSafari10
remove dead code
77452e9 
Signed-off-by: CodeSafari <codesafari10@gmail.com>
@aabidsofi19
Merge branch 'master' into webworkers
ace6846
@codeSafari10
Merge branch 'master' of github.com:meshery/meshery into webworkers
7816c94
@aabidsofi19
Copy link
Contributor

fixes : #11093

@aabidsofi19 aabidsofi19 merged commit 9981769 into meshery:master Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

Assignees
No one assigned
Labels
component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codeSafari10 @leecalcote @aabidsofi19