Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Fix list --count is not returning the total when page flag is present #11143

Merged

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Jun 10, 2024

Notes for Reviewers

This PR fixes #11142

Signed commits

  • Yes, I signed my commits.

New behavior

mesheryctl model list --count
Total number of models: 498

mesheryctl model list --count --page 3
Total number of models: 498

@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Jun 10, 2024
@lekaf974 lekaf974 changed the title fix(mesheryctl): Fix list --count is not returning the total when pag… [mesheryctl] Fix list --count is not returning the total when page flag is present Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

…e flag is present

Signed-off-by: mevrin <matthieu.evrin@gmail.com>
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 force-pushed the fix/mesheryctl-model-list-count-issue branch from db37bba to 761368b Compare June 10, 2024 01:30
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.23%. Comparing base (da4f44e) to head (761368b).
Report is 61 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11143   +/-   ##
=======================================
  Coverage    9.23%    9.23%           
=======================================
  Files         145      145           
  Lines       19014    19014           
=======================================
  Hits         1756     1756           
  Misses      16956    16956           
  Partials      302      302           
Flag Coverage Δ
unittests 9.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MUzairS15

This comment was marked as duplicate.

@MUzairS15 MUzairS15 merged commit 76e282a into meshery:master Jun 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] model list --count is not working properly
2 participants