-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow update to mail error log w/signoff #11156
workflow update to mail error log w/signoff #11156
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11156 +/- ##
==========================================
- Coverage 9.20% 9.19% -0.01%
==========================================
Files 145 145
Lines 19082 19091 +9
==========================================
Hits 1756 1756
- Misses 17024 17033 +9
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -417,6 +425,16 @@ func logModelGenerationSummary(modelToCompGenerateTracker *store.GenerticThreadS | |||
utils.Log.Info(fmt.Sprintf("-----------------------------\n-----------------------------\nGenerated %d models and %d components", totalAggregateModel, totalAggregateComponents)) | |||
} | |||
|
|||
func logError(err error, modelName string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need.
Use log instance, refer the existing approach which logs its output to registry log file.
Create a new log instance for errors logs when an error occurs use that log instance. As you initialize that instance set its log output to registry-generate-error.
Also make the directory structured, if you would.
logs/registry/1. log (contains logs of al severity except error logs) 2.
error (contains only error logs)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do so positively.
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
…an-0/meshery into workflowUpdateModelGenerate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this new email replace the existing email for this workflow or will it be a duplicate?
This will replace the component generator failure email in these scenarios:
For the scenario if the generator works and updater fails.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notes for Reviewers
Update the workflow to send error logs whenever an error occurs while running mesheryctl registry generate. Additionally, create a new file to store only the errors.
Local run of the workflow.
Signed commits