Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] fix crash of connections page #11171

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Jun 13, 2024

Notes for Reviewers

This PR fixes #11116

Issues which were fixed due to crash happening

  • wraps the sistent tooltip using sistentwrapper
  • remove the use of moment lib and use our own custom dateFormatter
  • re add column update state inside useeffect
  • environments properly load now

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
@sudhanshutech sudhanshutech added the kind/bug Something isn't working label Jun 13, 2024
@github-actions github-actions bot added the component/ui User Interface label Jun 13, 2024
Copy link

@sudhanshutech
Copy link
Member Author

@Yashsharma1911

@sudhanshutech sudhanshutech merged commit e926605 into master Jun 13, 2024
10 checks passed
@sudhanshutech sudhanshutech deleted the fix/crash/connections branch June 13, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extensions] Bug while trying to see connections
1 participant