remove Logrus with meshkit logger w/signoff #11176
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Jougan-0
changed the title
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11176 +/- ##
==========================================
- Coverage 9.19% 9.19% -0.01%
==========================================
Files 145 145
Lines 19088 19105 +17
==========================================
Hits 1756 1756
- Misses 17030 17047 +17
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
|
@Jougan-0 Thank you for your contribution. |
This is not a website topic so I don't think we should cover this in website's meeting. |
Signed-off-by: Shlok Mishra <99207534+Jougan-0@users.noreply.github.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
server/cmd/error.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| ErrCreatingRegoInstance = errors.New(ErrCreateRegoInstanceCode, errors.Alert, []string{"Error creating Rego Instance."}, []string{"Unable to create Rego instance, policies will not be evaluated."}, []string{}, []string{}) |
There was a problem hiding this comment.
I wonder if this shouldn't be "OPA Instance"
server/handlers/error.go
Outdated
| ErrInvalidGenValue = errors.New(ErrInvalidGenValueCode, errors.Alert, []string{"Invalid value for gen"}, []string{}, []string{}, []string{"please provide a valid value for gen (load generator)"}) | ||
| ErrParseDuration = errors.New(ErrParseDurationCode, errors.Alert, []string{"error parsing test duration"}, []string{}, []string{"The format of the duration passed could be incorrect"}, []string{"please refer to: https://docs.meshery.io/guides/mesheryctl#performance-management"}) | ||
| ErrPerformanceTest = errors.New(ErrPerformanceTestCode, errors.Alert, []string{"Load test error"}, []string{}, []string{"Load test endpoint could be not reachable"}, []string{"Make sure load test endpoint is reachable"}) | ||
| ErrInvalidK8SConfigNil = errors.New(ErrInvalidK8SConfigNilCode, errors.Alert, []string{"No valid kubernetes config found. Make sure to pass contextIDs in query parameters."}, []string{"Kubernetes config is not initialized with Meshery"}, []string{"Kubernetes config is not accessible to meshery or not valid"}, []string{"Upload your kubernetes config via the settings dashboard. If uploaded, wait for a minute for it to get initialized"}) |
There was a problem hiding this comment.
Always capitalize Kubernetes.
There was a problem hiding this comment.
Please update this for all errors.
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Notes for Reviewers
This PR fixes #11024
Still some instance left I am working on them.
Here is an update pr on the issue.
Signed commits