[Chore] Add permission check for reset database #11193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
|
|
leecalcote
reviewed
Jun 16, 2024
There was a problem hiding this comment.
LGTM.
It would be nice if in addition to the cursor: not-allowed indicator, if we also included a tooltip that explains the missing required permission. // @sudhanshutech @Yashsharma1911
leecalcote
approved these changes
Jun 16, 2024
Makes sense @leecalcote, I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR adds CASL check for reset database button.
Signed commits