[mesheryctl] Add support for EKS config #1995
Conversation
probot-autolabeler
bot
added
component/mesheryctl
|
Yay! |
1 similar comment
|
Yay! |
mesheryctl/pkg/utils/scripts.go
Outdated
| set -e | ||
| set -o pipefail | ||
|
|
||
| TARGET_FOLDER="/tmp/meshery/" |
There was a problem hiding this comment.
@hexxdump can we avoid use of a temp location and use Meshery's application folder instead? ~/.meshery
There was a problem hiding this comment.
Looking fine to me after the directory update. Need to test it out!
leecalcote
requested review from
sladyn98,
ameyaagashe,
nidhinmahesh and
nitishvu
Add support for "mesheryctl system config eks" Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>
mesheryctl/pkg/utils/scripts.go
Outdated
| set -e | ||
| set -o pipefail | ||
|
|
||
| TARGET_FOLDER="~/.meshery/" |
There was a problem hiding this comment.
@hexxdump can we avoid creating a new directory? We can reuse the user's existing MesheryFolder (https://github.com/layer5io/meshery/blob/master/mesheryctl/pkg/utils/helpers.go#L63).
There was a problem hiding this comment.
This portion of the command can be done in golang. Let's put as little as possible into shell script.
| REGION_NAME=%s | ||
| CLUSTER_NAME="%s" | ||
|
|
||
| create_target_folder() { |
mesheryctl/pkg/utils/scripts.go
Outdated
|
|
||
| create_update_kubeconfig() { | ||
| echo -e "\\nQuerying the kubernetes configuration for cluster ${CLUSTER_NAME} from EKS..." | ||
| aws eks --region ${REGION_NAME} update-kubeconfig --name ${CLUSTER_NAME} --kubeconfig ${KUBECONFIG} |
There was a problem hiding this comment.
We need to try / catch when using aws. Let's first check for the availability of this requisite dependency.
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>
|
✔️ Deploy preview for meshery-docs ready! 🔨 Explore the source changes: faad8e5 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ff777fee6d4d20007a2d133 😎 Browse the preview: https://deploy-preview-1995--meshery-docs.netlify.app |
|
Thank you, @hexxdump |
[mesheryctl] Add support for EKS config
Signed-off-by: Hussaina Begum Nandyala hexxdump@gmail.com
Description
Add support for "mesheryctl system config eks"
This PR fixes #
Notes for Reviewers
Could not test the changes as I do not have EKS cluster.
Signed commits