Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default location from usage test and let cobra handle that #2032

Conversation

anirudhjain75
Copy link
Member

Description

This PR fixes #1994

Notes for Reviewers

Signed commits

  • [.] Yes, I signed my commits.

@probot-autolabeler probot-autolabeler bot added component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang labels Dec 3, 2020
@anirudhjain75 anirudhjain75 force-pushed the fix-duplicate-listing-of-config-location branch from d54c489 to fa99b1c Compare December 3, 2020 07:49
Copy link
Contributor

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run gofmt

@kushthedude kushthedude added the pr/do-not-merge PRs not ready to be merged label Dec 6, 2020
Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
@anirudhjain75 anirudhjain75 force-pushed the fix-duplicate-listing-of-config-location branch from fa99b1c to 5af0466 Compare December 8, 2020 14:44
@netlify
Copy link

netlify bot commented Dec 8, 2020

Deploy preview for meshery-docs ready!

Built with commit 5af0466

https://deploy-preview-2032--meshery-docs.netlify.app

@anirudhjain75
Copy link
Member Author

@kushthedude @leecalcote Sorry for keeping this stale. gofmt'ed the file and pushed. Do review and merge :)

Copy link
Contributor

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@leecalcote leecalcote merged commit ab1567e into meshery:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang pr/do-not-merge PRs not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Duplicate listing of meshery config file location in global flag help
3 participants