Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Modified to create changelog file for release #2039

Merged
merged 1 commit into from Dec 21, 2020
Merged

CI: Modified to create changelog file for release #2039

merged 1 commit into from Dec 21, 2020

Conversation

SudhanAruna
Copy link
Contributor

@SudhanAruna SudhanAruna commented Dec 5, 2020 •
edited

Signed-off-by: Arunagirinadan Sudharshan sudhan.aruna.97@gmail.com

Description

This PR fixes #510

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@probot-autolabeler probot-autolabeler bot added the area/ci Continuous Integration label Dec 5, 2020
@SudhanAruna
Copy link
Contributor Author

Please let me know your feedback on these changes.

@leecalcote
Copy link
Member

@SudhanAruna thank you. This is a step in the right direction. Ideally, the Releases page will automatically reflect change logs from each release. Given the current direction of this workflow, a way that we can achieve the goal of having the Releases page automatically updated is to:

  1. Create a Jekyll datafile to track release notes (or create a new Jekyll collection in which each a file is created for each release made).
  2. Modify the Releases page to use this new Jekyll datafile / collection.

@leecalcote
Copy link
Member

Thank you, @SudhanAruna. Let @chandrashritii or me know if you stumble on any aspect of the Jekyll work and either one of us will help.

@leecalcote
Copy link
Member

@SudhanAruna any progress here? Anything I can help with?

@netlify
Copy link

netlify bot commented Dec 16, 2020 •
edited

✔️ Deploy preview for meshery-docs canceled.

🔨 Explore the source changes: 68b6f01

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe0ce8c7dfa8700070c976c

😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5fe0ce8c7dfa8700070c976c

@SudhanAruna
Copy link
Contributor Author

@leecalcote Please let me your feed back on this approach.

@SudhanAruna
CI: Modified release-drafter.yml to create release note with drafted …
68b6f01 
…content

Signed-off-by: Arunagirinadan Sudharshan <sudhan.aruna.97@gmail.com>
leecalcote
leecalcote approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudhanAruna 💥 Nice!

@leecalcote leecalcote merged commit d66334b into meshery:master Dec 21, 2020
@leecalcote leecalcote mentioned this pull request Dec 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@jesuslerma jesuslerma Awaiting requested review from jesuslerma

Assignees
No one assigned
Labels
area/ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Automate the updating of Releases docs page as part of CI release process.
2 participants
@SudhanAruna @leecalcote