-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GraphQL capability using Relay #2065
Conversation
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@dhruv0000 will this be ready for demo on Thursday? |
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
A couple conflicts to address, but nearly ready for review, @dhruv0000 ? |
Yes. Let's merge this by tonight. |
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe run gofmt on go code for ci checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruv0000 @vineethvanga18 please address the conflicts in this PR.
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a clean bill of health. :)
Will you address? - https://github.com/layer5io/meshery/pull/2065/checks?check_run_id=1630630058#step:3:68
Description
This PR fixes #
Notes for Reviewers
Signed commits