Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GraphQL capability using Relay #2065

Closed
wants to merge 16 commits into from

Conversation

dhruv0000
Copy link
Member

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Dev Kalra and others added 7 commits December 6, 2020 20:28
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@probot-autolabeler probot-autolabeler bot added component/ui User Interface language/go Issues or pull requests that use Golang language/javascript Issues or pull requests that use Javascript or React labels Dec 8, 2020
Dev Kalra and others added 4 commits December 10, 2020 14:22
Signed-off-by: Dev Kalra <kalradev@outlook.com>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@leecalcote
Copy link
Member

@dhruv0000 will this be ready for demo on Thursday?

Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@leecalcote
Copy link
Member

A couple conflicts to address, but nearly ready for review, @dhruv0000 ?

@dhruv0000
Copy link
Member Author

Yes. Let's merge this by tonight.

Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
@dhruv0000 dhruv0000 marked this pull request as ready for review December 20, 2020 00:31
Copy link
Contributor

@vineethvanga18 vineethvanga18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe run gofmt on go code for ci checks

Signed-off-by: leecalcote <leecalcote@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruv0000 @vineethvanga18 please address the conflicts in this PR.

Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruv0000
Copy link
Member Author

#2250 and #2 in meshery-extentions makes this PR no longer required.

@dhruv0000 dhruv0000 closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface language/go Issues or pull requests that use Golang language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants