Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: seperate website build from meshery #2082

Merged
merged 2 commits into from Dec 15, 2020
Merged

feat: seperate website build from meshery #2082

merged 2 commits into from Dec 15, 2020

Conversation

kushthedude
Copy link
Contributor

Signed-off-by: Kush Trivedi kushthedude@gmail.com

Description

This PR fixes #2022

@probot-autolabeler probot-autolabeler bot added the area/ci Continuous Integration label Dec 13, 2020
@netlify
Copy link

netlify bot commented Dec 13, 2020 •
edited

Deploy preview for meshery-docs ready!

Built with commit 42c4992

https://deploy-preview-2082--meshery-docs.netlify.app

@probot-autolabeler probot-autolabeler bot added area/docs Documentation update needed component/ui User Interface language/javascript Issues or pull requests that use Javascript or React language/markdown Issues or pull requests that use Markdown labels Dec 13, 2020
@kushthedude
feat: seperate website build from meshery
5320e35 
Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
@kushthedude
corrected tpy
42c4992 
Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
@kushthedude
Copy link
Contributor Author

@leecalcote We have a website build check instead of many golang specific checks for the documentation PR now 😄

@kushthedude kushthedude removed component/ui User Interface language/javascript Issues or pull requests that use Javascript or React language/markdown Issues or pull requests that use Markdown labels Dec 13, 2020
leecalcote
leecalcote approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When the docs build is done, this won’t have a deploy preview, but will confirm that the docs are building, right?

@kushthedude
Copy link
Contributor Author

ooks good. When the docs build is done, this won’t have a deploy preview, but will confirm that the docs are building, right?

Yes

@leecalcote leecalcote merged commit b1ca936 into meshery:master Dec 15, 2020
@kushthedude kushthedude deleted the labelSort branch December 15, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
area/ci Continuous Integration area/docs Documentation update needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Do not run golangci-lint, docker build and other related workflows on PRs with the docs label.
2 participants
@kushthedude @leecalcote