Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update site permalinks #2084

Merged
merged 6 commits into from Dec 21, 2020
Merged

[Docs] Update site permalinks #2084

merged 6 commits into from Dec 21, 2020

Conversation

chandrashritii
Copy link
Contributor

Signed-off-by: Shriti shritichan@gmail.com

Description

Updated all broken permalinks. This PR follows up with #2016 and fixes #2067.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shriti <shritichan@gmail.com>
@probot-autolabeler probot-autolabeler bot added area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown labels Dec 14, 2020
@netlify
Copy link

netlify bot commented Dec 14, 2020

✔️ Deploy preview for meshery-docs ready!

🔨 Explore the source changes: 68b36bc

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe10fa390806a0008060fa5

😎 Browse the preview: https://deploy-preview-2084--meshery-docs.netlify.app

@leecalcote
Copy link
Member

leecalcote commented Dec 16, 2020

@chandrashritii there are couple conflicts to attend to

@@ -61,7 +61,7 @@ The ({{page.name}}) includes a handful of sample applications. Use Meshery to de

Meshery allows you to analyze the compliance status and functional capabilities of your service mesh. This allows you to compare high-level functional differences between service meshes and verify whether your service mesh is conformant with the SMI specification.

Learn more about the SMI specification and [Meshery's conformance test suite](https://docs.meshery.io/functionality/smi-conformance).
Learn more about the SMI specification and [Meshery's conformance test suite](https:/{{ site.baseurl }}.meshery.io/functionality/smi-conformance).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at this again.

- The sample BookInfo application displays information about a book, similar to a single catalog entry of an online book store.

### SMI Conformance Capability

Meshery allows you to analyze the compliance status and functional capabilities of your service mesh. This allows you to compare high-level functional differences between service meshes and verify whether your service mesh is conformant with the SMI specification.

Learn more about the SMI specification and [Meshery's conformance test suite](https://docs.meshery.io/functionality/smi-conformance).
Learn more about the SMI specification and [Meshery's conformance test suite]({{ site.baseurl }}/functionality/smi-conformance).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect link.

- A microservice application that allows users to vote for their favorite emoji, and tracks votes received on a leaderboard.

- [Bookinfo](/docs/guides/sample-apps#bookinfo)
- [Bookinfo]({{ site.baseurl }}//guides/sample-apps#bookinfo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double backslash

@@ -37,7 +37,7 @@ Click on (+) and choose the `{{page.version}}` of the {{page.mesh_name}} service

Meshery allows you to analyze the compliance status and functional capabilities of your service mesh. This allows you to compare high-level functional differences between service meshes and verify whether your service mesh is conformant with the SMI specification.

Learn more about the SMI specification and [Meshery's conformance test suite](https://docs.meshery.io/functionality/smi-conformance).
Learn more about the SMI specification and [Meshery's conformance test suite]({{ site.baseurl }}/functionality/smi-conformance).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -137,7 +137,7 @@ export KUBECONFIG="$(k3d kubeconfig get 'k3s-default')"

#### 5. <a name="step5"><b>Instalar Meshery</b></a>

Siga los [pasos de instalación](/docs/pages/es/installation/windows.md) para instalar el CLI mesheryctl. Luego, ejecute:
Siga los [pasos de instalación]({{ site.baseurl }}/pages/es/installation/windows.md) para instalar el CLI mesheryctl. Luego, ejecute:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pages?

- Fixed links
- Fixed search icon

Signed-off-by: Shriti <shritichan@gmail.com>
@leecalcote
Copy link
Member

Do sync with latest master.

@@ -1,6 +1,6 @@
---
layout: page
title: Meshery Documentation
title:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the titles in place and control with the display-title attribute.

Meshery should now be running in your AKS cluster and the Meshery UI should be locally accessible. Navigate to [http://localhost:9081](http://localhost:9081) to log into Meshery.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong port number; broken link

@leecalcote leecalcote merged commit 1f45f41 into meshery:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: http://docs.meshery.io/docs/installation/platforms/minikube
2 participants