Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Pre-run check before checking system version #2109

Merged
merged 5 commits into from Jan 2, 2021
Merged

[mesheryctl] Pre-run check before checking system version #2109

merged 5 commits into from Jan 2, 2021

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Dec 17, 2020

Signed-off-by: Uddeshya Singh singhuddeshyaofficial@gmail.com

Description
Runs additional pre-run check like mesheryctl system update

This PR fixes #2100

Notes for Reviewers
Sample logs are as follows

Docker is not running.
Start Docker now [y/n]? y
Attempting to start Docker...
[sudo] password for uddeshya: 
Prerequisite Docker started.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Uddeshya Singh <singhuddeshyaofficial@gmail.com>
@probot-autolabeler probot-autolabeler bot added component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang labels Dec 17, 2020
@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for meshery-docs canceled.

🔨 Explore the source changes: 0ad9bad

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe46e3003eb4200086541a2

😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5fe46e3003eb4200086541a2

kushthedude
kushthedude previously approved these changes Dec 17, 2020
@leecalcote
Copy link
Member

leecalcote commented Dec 17, 2020

@uds5501 thank you. We will want I land this check in the update flow. The title of error #2100 is accurate, but misleading. The error in #2100 occurred during an update operation.

In addition to handling the update flow, another consideration here is to ensure that users are allowed to check version without running Docker of Meshery server. In the case of the user simply running “mesheryctl version”, we don’t want to prompt them to start Meshery server if it is not running. But, do want to prompt them to run Meshery if they try to update version.

@uds5501
Copy link
Contributor Author

uds5501 commented Dec 22, 2020

@leecalcote so basically this check should run once the user agrees for an update, correct?

leecalcote
leecalcote previously approved these changes Dec 23, 2020
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501, yes, correct.

@leecalcote leecalcote self-requested a review December 23, 2020 00:50
Signed-off-by: leecalcote <leecalcote@gmail.com>
@leecalcote leecalcote dismissed stale reviews from kushthedude and themself via 4318816 December 23, 2020 00:52
@@ -2,6 +2,7 @@
mesheryctl/cmd/mesheryctl/mesheryctl
mesheryctl/.meshery/
mesheryctl/mesheryctl
mesheryctl/default.profraw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @uds5501 😀

@leecalcote leecalcote merged commit 5e6574c into meshery:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] version fails to update when Docker is not running
3 participants