New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mesheryctl] Pre-run check before checking system version #2109
Conversation
Signed-off-by: Uddeshya Singh <singhuddeshyaofficial@gmail.com>
✔️ Deploy preview for meshery-docs canceled. 🔨 Explore the source changes: 0ad9bad 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe46e3003eb4200086541a2 😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5fe46e3003eb4200086541a2 |
@uds5501 thank you. We will want I land this check in the In addition to handling the update flow, another consideration here is to ensure that users are allowed to check version without running Docker of Meshery server. In the case of the user simply running “mesheryctl version”, we don’t want to prompt them to start Meshery server if it is not running. But, do want to prompt them to run Meshery if they try to update version. |
@leecalcote so basically this check should run once the user agrees for an update, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uds5501, yes, correct.
Signed-off-by: leecalcote <leecalcote@gmail.com>
4318816
@@ -2,6 +2,7 @@ | |||
mesheryctl/cmd/mesheryctl/mesheryctl | |||
mesheryctl/.meshery/ | |||
mesheryctl/mesheryctl | |||
mesheryctl/default.profraw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @uds5501 😀
Signed-off-by: Uddeshya Singh singhuddeshyaofficial@gmail.com
Description
Runs additional pre-run check like
mesheryctl system update
This PR fixes #2100
Notes for Reviewers
Sample logs are as follows
Signed commits