Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Modified release page to use release collections #2114

Merged
merged 1 commit into from Dec 21, 2020

Conversation

SudhanAruna
Copy link
Contributor

@SudhanAruna SudhanAruna commented Dec 19, 2020

Description
In this PR release page is modified to use release collection to display the release versions with separate markdown file
for each release.
This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@probot-autolabeler probot-autolabeler bot added area/ci Continuous Integration area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown labels Dec 19, 2020
@netlify
Copy link

netlify bot commented Dec 19, 2020

✔️ Deploy preview for meshery-docs ready!

🔨 Explore the source changes: 1fb394a

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fde46b1cbcbe800076c0c06

😎 Browse the preview: https://deploy-preview-2114--meshery-docs.netlify.app

@SudhanAruna SudhanAruna changed the title Release markdown files Docs: Modified release page to use release collections Dec 19, 2020
docs/_config.yml Show resolved Hide resolved
docs/_layouts/releasepage.html Outdated Show resolved Hide resolved
…erate release markdown files

Signed-off-by: Arunagirinadan Sudharshan <sudhan.aruna.97@gmail.com>
@leecalcote
Copy link
Member

@SudhanAruna, well done! One small item to deal with here: the descending order of releases by version number is being itemized slightly out of order with the string “v0.4.9” coming before “v0.4.25", because the “9” is greater than “2", as opposed to “25” being greater than “9".

@leecalcote
Copy link
Member

#2126 has been opened to track the ordering of releases.

Super fantastic work here, @SudhanAruna. It's been 16 months since this challenge was first presented to the community. Way to tackle it!

@leecalcote leecalcote merged commit 63f304b into meshery:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants