Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch version from ldflags #2124

Merged
merged 2 commits into from Dec 21, 2020
Merged

Conversation

anirudhjain75
Copy link
Member

Signed-off-by: Anirudh Jain anirudh.jain@outlook.com

Fetch version and commit sha from ldflags passed into it on build time

Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
@probot-autolabeler probot-autolabeler bot added component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang labels Dec 21, 2020
@netlify
Copy link

netlify bot commented Dec 21, 2020

✔️ Deploy preview for meshery-docs canceled.

🔨 Explore the source changes: 1bb40ad

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe104c39e914300072b1fd2

😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5fe104c39e914300072b1fd2

leecalcote
leecalcote previously approved these changes Dec 21, 2020
Signed-off-by: leecalcote <leecalcote@gmail.com>
@probot-autolabeler probot-autolabeler bot added the component/api Issues related to API label Dec 21, 2020
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 51a23c0 into meshery:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api Issues related to API component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants