[WIP] UI Extension points #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
probot-autolabeler
bot
added
component/ui
|
✔️ Deploy preview for meshery-docs canceled. 🔨 Explore the source changes: 63f2a49 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5feabe8e7eb00700084467cf 😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5feabe8e7eb00700084467cf |
leecalcote
reviewed
Dec 28, 2020
leecalcote
reviewed
Dec 28, 2020
leecalcote
requested changes
Dec 28, 2020
This was referenced Dec 29, 2020
leecalcote
reviewed
Dec 29, 2020
| @@ -28,6 +29,11 @@ var ( | |||
| commitsha = "Not Set" | |||
| ) | |||
|
|
|||
| const ( | |||
| // SAAS_BASE_URL_NONE is the saas base url for the "none" provider | |||
| SAAS_BASE_URL_NONE = "https://meshery.layer5.io" | |||
There was a problem hiding this comment.
Suggested change
| SAAS_BASE_URL_NONE = "https://meshery.layer5.io" | |
| local_provider_URL = "https://meshery.layer5.io" |
leecalcote
reviewed
Dec 29, 2020
| @@ -28,6 +29,11 @@ var ( | |||
| commitsha = "Not Set" | |||
| ) | |||
|
|
|||
| const ( | |||
| // SAAS_BASE_URL_NONE is the saas base url for the "none" provider | |||
There was a problem hiding this comment.
Suggested change
| // SAAS_BASE_URL_NONE is the saas base url for the "none" provider | |
| // local_provider_URL is the saas base url for the Local Provider "None" |
leecalcote
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a system of extensibility by defining specific points within Meshery's code base in which Meshery's functionality may be dynamically augmented. See Meshery Documentation's "Extensibility" page for additional details.
Signed commits