Add SAAS_BASE_URL to docker-compose again to support stable release #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleases Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
|
✔️ Deploy preview for meshery-docs canceled. 🔨 Explore the source changes: 053f5f1 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fef7d111bd5f600079bb076 😎 Browse the preview: https://app.netlify.com/sites/meshery-docs/deploys/5fef7d111bd5f600079bb076 |
leecalcote
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Utkarsh Srivastava srivastavautkarsh8097@gmail.com
Description
This PR fixes #2165
SAAS_BASE_URL environment variable was removed from docker-compose.yaml in an effort to move to support multiple remote providers but
mesheryctl system startinternally uses this compose file to spin upstablerelease of meshery which doesn't yet support the new environmental variable and needsSAAS_BASE_URLenv variable in order to work properly, hence adding it back again.Notes for Reviewers
Signed commits