Replace hardcoded URL with Endpoints from context #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy preview for meshery-docs failed. 🔨 Explore the source changes: b51666b 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ff61f083f4888000826e56b |
probot-autolabeler
bot
added
component/mesheryctl
anirudhjain75
changed the title
|
While you're updating the cfg package, @anirudhjain75, perhaps, change it's name to "config"... |
|
Sure @leecalcote |
|
Hey @leecalcote , Version command is now context aware |
anirudhjain75
force-pushed
the
integrate
branch
2 times, most recently
from
e1b58ae
to
99c3bf4
Compare
|
A couple conflicts to knock out... |
…. Rework cfg.go to config.go with required design and architecture changes to support context. Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
Signed-off-by: Anirudh Jain <anirudh.jain@outlook.com>
anirudhjain75
force-pushed
the
integrate
branch
from
2e008b5
to
b51666b
Compare
leecalcote
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anirudh Jain anirudh.jain@outlook.com