Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace route2 to intercept command in Cypress tests #2216

Merged

Conversation

ramrodo
Copy link
Member

@ramrodo ramrodo commented Jan 6, 2021

Signed-off-by: Rodolfo Martínez Vega rodomar@outlook.com

Description

This PR updates the route2 command deprecated usage to use intercept. The latest is recommended to use since Cypress 6.0.0

This PR is related to #2021

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@probot-autolabeler probot-autolabeler bot added component/ui User Interface language/javascript Issues or pull requests that use Javascript or React labels Jan 6, 2021
@netlify
Copy link

netlify bot commented Jan 6, 2021

✔️ Deploy preview for meshery-docs ready!

🔨 Explore the source changes: f102359

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ff627fb58c9ec0007f06cd5

😎 Browse the preview: https://deploy-preview-2216--meshery-docs.netlify.app

@ramrodo ramrodo force-pushed the update-to-intercept-command-for-cypress branch from a9fee3a to f102359 Compare January 6, 2021 21:13
Signed-off-by: Rodolfo Martínez Vega <rodomar@outlook.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. 👍

@leecalcote leecalcote merged commit 48507c3 into meshery:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants