Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotecomponent for userpref #2227

Merged
merged 3 commits into from Jan 9, 2021

Conversation

vineethvanga18
Copy link
Contributor

Description

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@probot-autolabeler probot-autolabeler bot added component/ui User Interface language/javascript Issues or pull requests that use Javascript or React labels Jan 7, 2021
@netlify
Copy link

netlify bot commented Jan 7, 2021

❌ Deploy preview for meshery-docs failed.

🔨 Explore the source changes: d910c9f

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ff90cbf94339900075c77c9

Signed-off-by: vineethvanga18 <reddy.8@iitj.ac.in>
@leecalcote
Copy link
Member

@vineethvanga18 will you update the Meshery Extensibility document accordingly?

@leecalcote
Copy link
Member

@vineethvanga18 I get a blank screen.
Screen Shot 2021-01-07 at 7 36 09 PM

@vineethvanga18
Copy link
Contributor Author

That is because we still don't get user_pref component from the extensions end point

@hwpplayer1
Copy link
Contributor

hwpplayer1 commented Jan 8, 2021

That is because we still don't get user_pref component from the extensions end point

Could you please point the lines between the working code and "breakline" To be faster then of course i will read all code but we run fast that is why i need a tip

@leecalcote
Copy link
Member

That is because we still don't get user_pref component from the extensions end point

@vineethvanga18 the two preferences for anonymous test results and statistics should be part of Meshery's core, while MeshMap preferences should be part of the extension.

vineethvanga18 and others added 2 commits January 9, 2021 07:22
Co-authored-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
@vineethvanga18
Copy link
Contributor Author

That is because we still don't get user_pref component from the extensions end point

@vineethvanga18 the two preferences for anonymous test results and statistics should be part of Meshery's core, while MeshMap preferences should be part of the extension.

I just realized you were on ui-dev-server. Those preferences are fetched from "/api/user/stats" and for them to show up you got to run meshery server too. @leecalcote

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see now! Thanks, @vineethvanga18

@leecalcote leecalcote merged commit c7dae39 into meshery:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants