New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remotecomponent for userpref #2227
Conversation
❌ Deploy preview for meshery-docs failed. 🔨 Explore the source changes: d910c9f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ff90cbf94339900075c77c9 |
Signed-off-by: vineethvanga18 <reddy.8@iitj.ac.in>
0345ddc
to
8c8f95a
Compare
@vineethvanga18 will you update the Meshery Extensibility document accordingly? |
@vineethvanga18 I get a blank screen. |
That is because we still don't get user_pref component from the extensions end point |
Could you please point the lines between the working code and "breakline" To be faster then of course i will read all code but we run fast that is why i need a tip |
@vineethvanga18 the two preferences for anonymous test results and statistics should be part of Meshery's core, while MeshMap preferences should be part of the extension. |
Co-authored-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
I just realized you were on ui-dev-server. Those preferences are fetched from "/api/user/stats" and for them to show up you got to run meshery server too. @leecalcote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see now! Thanks, @vineethvanga18
Description
Notes for Reviewers
Signed commits