Fix performance test result download #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
probot-autolabeler
bot
added
component/mesheryctl
|
✔️ Deploy preview for meshery-docs ready! 🔨 Explore the source changes: 1b4a484 🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5ffaf8011bc89a0008e3b7c0 😎 Browse the preview: https://deploy-preview-2238--meshery-docs.netlify.app |
|
@NJnisarg, a good PR to review. |
leecalcote
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the performance test results download.
The constructed URL for SMP results was malformed which was fixed in this PR.
Notes for Reviewers
golangci lint was failing in the previous PRs checks, this PR also attempts fix that issue.
Signed commits