Adding Operator Settings in Environments Tab #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
probot-autolabeler
bot
added
component/ui
|
@dhruv0000 what remains to complete here? |
|
The API endpoint updates the data only when the component is loaded or changed. Need a better solution like SSEs or graphQL subscription to be implemented, or else the user would have to click the chip to update the data. Except that, the PR is good to go. |
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
probot-autolabeler
bot
added
component/api
Signed-off-by: dhruv0000 <patel.4@iitj.ac.in>
|
The PR is good to go @leecalcote. |
|
Good to go! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2214
Notes for Reviewers
Signed commits