Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Build and Release (CI) page #2252

Merged
merged 2 commits into from Jan 15, 2021
Merged

[Docs] Build and Release (CI) page #2252

merged 2 commits into from Jan 15, 2021

Conversation

leecalcote
Copy link
Member

@leecalcote leecalcote commented Jan 15, 2021 •
edited

Notes for Reviewers

This PR publishes much of the Meshery Build & Release document.

Signed commits

  • Yes, I signed my commits.

@leecalcote
adding build and release details
d2da09b 
Signed-off-by: leecalcote <leecalcote@gmail.com>
@probot-autolabeler probot-autolabeler bot added area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown labels Jan 15, 2021
@leecalcote
the rest
e5ac689 
Signed-off-by: leecalcote <leecalcote@gmail.com>
MukulMaheshwari
MukulMaheshwari approved these changes Jan 15, 2021
View reviewed changes
Copy link

@MukulMaheshwari MukulMaheshwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine @leecalcote. Much needed thing.

Aisuko
Aisuko approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit d291623 into master Jan 15, 2021
@Aisuko Aisuko deleted the leecalcote/docs/build-release branch January 15, 2021 11:46
mgfeller
mgfeller reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@mgfeller mgfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (too late but anyway :smile) )

@leecalcote
Copy link
Member Author

That @Aisuko... he's quick on the draw. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgfeller mgfeller mgfeller left review comments

@Aisuko Aisuko Aisuko approved these changes

@MukulMaheshwari MukulMaheshwari MukulMaheshwari approved these changes

@naturalett naturalett Awaiting requested review from naturalett

@SudhanAruna SudhanAruna Awaiting requested review from SudhanAruna

@jesuslerma jesuslerma Awaiting requested review from jesuslerma

@alonsolopezr alonsolopezr Awaiting requested review from alonsolopezr

@chaltenio chaltenio Awaiting requested review from chaltenio

@shubhank-saxena shubhank-saxena Awaiting requested review from shubhank-saxena

Assignees
No one assigned
Labels
area/docs Documentation update needed language/markdown Issues or pull requests that use Markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leecalcote @mgfeller @Aisuko @MukulMaheshwari