[mesheryctl] Make 'system reset' context aware

[pottekkat]

Signed-off-by: navendu-pottekkat navendupottekkat@gmail.com

Description

This PR fixes #2248

Notes for Reviewers

This is a draft PR and is not ready for review.

Signed commits

• Yes, I signed my commits.

[anirudhjain75]

This is still a WIP do ping me when you're partially or completely done. Or if you need my help. As far as I can see the changes are yet to be implemented

[pottekkat]

@anirudhjain75 @leecalcote Yes, this is a WIP. I still have to implement the fetch from GitHub using the API part. I will try to get it done today.

[pottekkat]

@leecalcote @anirudhjain75 I have made a basic fix for this issue that seem to be working while I tested locally. I still need to setup some error handling for all possible scenarios. But this works and please check it and let me know for any changes.

[leecalcote]

@navendu-pottekkat, I don't believe that this was part of the original ask, but will you consider support of the -c flag for temporarily overriding the current context? Support for this at the system level is coming. @anirudhjain75 does any consideration need to be made here in order to support -c as written here - https://github.com/layer5io/meshery/pull/2256/files#diff-3ec6eb99922674fe5326ef77839a41f6e5356441ffebb8501c2196ace27a93aaR71?

I assume not given that the system level support should provide this to all system level commands.

[leecalcote]

The system level struct should be filtering any invalid values for channel and version, so confirmation of valid values shouldn't have to be considered here.

@anirudhjain75 will you confirm that this is the case?

[pottekkat]

@navendu-pottekkat, I don't believe that this was part of the original ask, but will you consider support of the -c flag for temporarily overriding the current context? Support for this at the system level is coming. @anirudhjain75 does any consideration need to be made here in order to support -c as written here - https://github.com/layer5io/meshery/pull/2256/files#diff-3ec6eb99922674fe5326ef77839a41f6e5356441ffebb8501c2196ace27a93aaR71?

I assume not given that the system level support should provide this to all system level commands.

I think it is better to raise this as a separate issue and make a new PR

[pottekkat]

@anirudhjain75 @leecalcote I have made the changes to the logs. It looks like this now-

navendu@navendu:~/Code/meshery-dev/meshery/mesheryctl$ ./mesheryctl system reset
Meshery resetting...

Current Context: local
Channel: stable
Version: v0.4.20

Fetching default docker-compose file at version: v0.4.20...

...Meshery config (/home/navendu/.meshery/meshery.yaml) now reset to default settings.

Overriding the context using the -c flag can be made into another issue and a separate PR can be made.

@anirudhjain75 Please review and merge this PR.

[hexxdump]

instead of default settings - can we print currVersion ? or default settings of currVersion?

[pottekkat]

instead of default settings - can we print currVersion ? or default settings of currVersion?

@hexxdump We are actually printing the version. Here v0.4.20 is the version.

Fetching default docker-compose file at version: v0.4.20...

...Meshery config (/home/navendu/.meshery/meshery.yaml) now reset to default settings.

[leecalcote]

@navendu-pottekkat, I don't believe that this was part of the original ask, but will you consider support of the -c flag for temporarily overriding the current context? Support for this at the system level is coming. @anirudhjain75 does any consideration need to be made here in order to support -c as written here - https://github.com/layer5io/meshery/pull/2256/files#diff-3ec6eb99922674fe5326ef77839a41f6e5356441ffebb8501c2196ace27a93aaR71?
I assume not given that the system level support should provide this to all system level commands.

I think it is better to raise this as a separate issue and make a new PR

Sounds real good. Let's do a new issue/PR.

[leecalcote]

Looking good. A follow up issue on "platform" support for "docker" and for -c flag...