Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Integration Test fix #4336

Merged

Conversation

piyushsingariya
Copy link
Contributor

Signed-off-by: Piyush Singariya piyushsingariya@gmail.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Piyush Singariya <piyushsingariya@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit be147fd into meshery:master Oct 6, 2021
@leecalcote leecalcote added the area/tests Testing / quality assurance label Oct 6, 2021
@piyushsingariya
Copy link
Contributor Author

don't merge please, tests are failing I need to see whyyyyyyyyy.

@piyushsingariya
Copy link
Contributor Author

😂

@leecalcote
Copy link
Member

Hahaha! My trigger finger is set to extremely sensitive today. Your update was a good change, though. 😂

@piyushsingariya
Copy link
Contributor Author

Cool, errors are popping up one after the another in the integration tests so it will take time, I need to make more alterations to figure out the culprit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Testing / quality assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants