Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate meshery/homebrew-tap #6477

Merged
merged 1 commit into from Nov 2, 2022
Merged

deprecate meshery/homebrew-tap #6477

merged 1 commit into from Nov 2, 2022

Conversation

nishantwrp
Copy link
Member

@nishantwrp nishantwrp commented Nov 2, 2022

Signed-off-by: Nishant Mittal mittalnishant14@outlook.com

Description

This PR fixes #5921

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nishant Mittal <mittalnishant14@outlook.com>
@leecalcote leecalcote added component/mesheryctl CLI for Meshery area/ci Continuous Integration labels Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This PR has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit a139d70 into meshery:master Nov 2, 2022
@leecalcote
Copy link
Member

@nishantwrp you had a good call out on today's Meshery Dev call regarding future semver compatibility consideration. If there isn't an open issue on this, please do open one to track the item.

@nishantwrp nishantwrp deleted the deprecate-custom-tap branch November 2, 2022 20:30
@nishantwrp
Copy link
Member Author

@leecalcote done, #6480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] deprecate meshery/homebrew-tap for publishing mesheryctl releases
2 participants