One golangci-lint workflow #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
acald-creator
force-pushed
the
lint-ci-workflow
branch
from
755d9c4
to
0f08e1a
Compare
|
Is segregating golang linting into its own workflow ideal? It would be good to address this in context of the spreadsheet that you're updating, @acald-creator (?) - https://docs.google.com/spreadsheets/d/13Ir4gfaKoAX9r8qYjAFFl_U9ntke4X5ndREY1T7bnVs/edit#gid=1214153102 |
|
Perhaps, a separate workflow that checks out the repo (again) and sets up golang (again) is less efficient? |
|
@acald-creator if we reuse the same linting workflow across the other workflows, separating it out might make sense. The build workflow is not referencing the golangci lint workflow here, though. |
Revolyssup
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonette Caldwell pullmana8@gmail.com
Description
This PR fixes #5993
Notes for Reviewers
Signed commits
For the purpose of this PR is to separate the
golangci-lintworkflow from the existing workflows, so that we can obtain the necessary reports from linting issues immediately, instead of stopping the existing workflow.There will still need to be another PR to update the linting settings, which I'm currently working on.