Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension] Meshery Server Registration #7065

Merged

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Feb 12, 2023

Notes for Reviewers

This PR is
fixes #7031
fixes #6963

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86 theBeginner86 added the pr/do-not-merge PRs not ready to be merged label Feb 12, 2023
@theBeginner86 theBeginner86 changed the title [WIP][extension] Meshery Server Registration [WIP][Extension] Meshery Server Registration Feb 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 16.52% // Head: 12.28% // Decreases project coverage by -4.25% ⚠️

Coverage data is based on head (71aff53) compared to base (24d2cdd).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7065      +/-   ##
==========================================
- Coverage   16.52%   12.28%   -4.25%     
==========================================
  Files         118      118              
  Lines       16201    16226      +25     
==========================================
- Hits         2677     1993     -684     
- Misses      13040    13911     +871     
+ Partials      484      322     -162     
Flag Coverage Δ
gointegrationtests ?
unittests 12.28% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cmd/main.go 0.00% <0.00%> (ø)
server/handlers/middlewares.go 0.00% <0.00%> (ø)
mesheryctl/internal/cli/root/system/start.go 1.56% <0.00%> (-54.07%) ⬇️
mesheryctl/internal/cli/root/system/status.go 1.51% <0.00%> (-53.79%) ⬇️
mesheryctl/internal/cli/root/system/stop.go 2.00% <0.00%> (-46.50%) ⬇️
mesheryctl/internal/cli/root/system/update.go 1.73% <0.00%> (-43.48%) ⬇️
mesheryctl/internal/cli/root/system/logs.go 4.00% <0.00%> (-42.67%) ⬇️
mesheryctl/internal/cli/root/system/restart.go 2.66% <0.00%> (-42.67%) ⬇️
mesheryctl/internal/cli/root/root.go 25.49% <0.00%> (-40.20%) ⬇️
mesheryctl/internal/cli/root/version.go 0.00% <0.00%> (-34.24%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86 theBeginner86 changed the title [WIP][Extension] Meshery Server Registration [Extension] Meshery Server Registration Feb 14, 2023
@theBeginner86 theBeginner86 added kind/enhancement Improvement in current feature and removed pr/do-not-merge PRs not ready to be merged labels Feb 14, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

theBeginner86 commented Feb 14, 2023

Need to add new meshkit errors.....

theBeginner86 and others added 5 commits February 14, 2023 22:40
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: leecalcote <leecalcote@gmail.com>
leecalcote
leecalcote previously approved these changes Feb 14, 2023
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theBeginner86 will you update this doc with a brief description of the enhancement to Meshery Server registration as a capability / extension point? https://docs.meshery.io/extensibility/providers#remote-provider-extension-points

Good work on this important system enhancement.

Signed-off-by: leecalcote <leecalcote@gmail.com>
leecalcote
leecalcote previously approved these changes Feb 15, 2023
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
…om/theBeginner86/meshery into theBeginner86/meshery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Feb 15, 2023
…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Feb 15, 2023

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Feb 15, 2023

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Feb 15, 2023

…hery-registration

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@l5io
Copy link
Collaborator

l5io commented Feb 15, 2023

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great demo today!

@leecalcote leecalcote merged commit 12c7626 into meshery:master Feb 15, 2023
@theBeginner86 theBeginner86 deleted the theBeginner86/meshery-registration branch February 16, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed component/server kind/enhancement Improvement in current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extensions] Remote Provider: Meshery Server Registration [Server] Register with Remote Provider
4 participants