Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Navigator Icons Consistent #7203

Merged
merged 3 commits into from Mar 2, 2023
Merged

Conversation

hs05june
Copy link
Member

Notes for Reviewers

This PR fixes #6860

2023-02-26.17-43-54.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: hs05june <harpreet.singh.cse21@itbhu.ac.in>
Signed-off-by: hs05june <harpreet.singh.cse21@itbhu.ac.in>
Signed-off-by: hs05june <harpreet.singh.cse21@itbhu.ac.in>
@github-actions github-actions bot added the component/ui User Interface label Feb 26, 2023
@hs05june
Copy link
Member Author

Hey @leecalcote @Abhishek-kumar09 Please review

@acald-creator acald-creator requested a review from a team February 26, 2023 16:59
@Abhishek-kumar09
Copy link
Member

Screenshot 2023-03-01 at 5 58 09 PM

Is it just black screen in recording, or something wrong with my system? // @hs05june

@hs05june
Copy link
Member Author

hs05june commented Mar 1, 2023

@Abhishek-kumar09 Seems like I have uploaded wrong video. My mistake.

@hs05june
Copy link
Member Author

hs05june commented Mar 1, 2023

2023-03-01.18-16-13.mp4

@Abhishek-kumar09

Copy link
Member

@Abhishek-kumar09 Abhishek-kumar09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 4df8c1b into meshery:master Mar 2, 2023
@hs05june hs05june deleted the newnavigator branch March 5, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Inconsistency in the sidebar icons
3 participants