Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs in dark mode by default and added icons #7248

Merged

Conversation

vishalvivekm
Copy link
Member

@vishalvivekm vishalvivekm commented Mar 1, 2023

Notes for Reviewers

This PR fixes #7190 #7208

  • sets dark mode as default Meshery docs theme
  • updates the mode toggle icons (currently there's same icon ☀ for both modes):

Screenshot_20230228_005336

Screenshot_20230228_005348

Signed commits
Signed-off-by: Vivek Vishal 110674407+vishalvivekm@users.noreply.github.com

  • Yes, I signed my commits.

Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Mar 1, 2023
@l5io
Copy link
Collaborator

l5io commented Mar 1, 2023

@leecalcote
Copy link
Member

@sudhanshutech what do you think?

@sudhanshutech
Copy link
Member

@sudhanshutech what do you think?

@leecalcote there is a flickering of dark mode when page reloads in light theme, @vishalvivekm the root cause is because the javascript is reloading after the page reloads. So here is a reference you can take @vishalvivekm https://dev.to/ayc0/light-dark-mode-avoid-flickering-on-reload-1567

@sudhanshutech
Copy link
Member

Let me know if you need help @vishalvivekm

Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented Mar 2, 2023

@vishalvivekm
Copy link
Member Author

Let me know if you need help @vishalvivekm

Hey, Thank you very much @sudhanshutech for the feedback! Please do checkout the new preview! The Flickering is gone ☺

I consider this to be the first and last change required in this PR @leecalcote @GaganpreetKaurKalsi

@sudhanshutech
Copy link
Member

Nice work @vishalvivekm 👍

@leecalcote
Copy link
Member

Thank you, gents.

@leecalcote leecalcote merged commit e237a7a into meshery:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation update needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Set dark mode as the default Meshery Docs theme
4 participants