-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs in dark mode by default and added icons #7248
docs in dark mode by default and added icons #7248
Conversation
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
🚀 Preview for commit 0bf4cb0 at: https://63ff9ff0990de2004eacad4a--meshery-docs-preview.netlify.app |
@sudhanshutech what do you think? |
@leecalcote there is a flickering of dark mode when page reloads in light theme, @vishalvivekm the root cause is because the javascript is reloading after the page reloads. So here is a reference you can take @vishalvivekm https://dev.to/ayc0/light-dark-mode-avoid-flickering-on-reload-1567 |
Let me know if you need help @vishalvivekm |
Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
🚀 Preview for commit c04e043 at: https://6400740a9890866a17e26ff1--meshery-docs-preview.netlify.app |
Hey, Thank you very much @sudhanshutech for the feedback! Please do checkout the new preview! The Flickering is gone ☺ I consider this to be the first and last change required in this PR @leecalcote @GaganpreetKaurKalsi |
Nice work @vishalvivekm 👍 |
Thank you, gents. |
Notes for Reviewers
This PR fixes #7190 #7208
Signed commits
Signed-off-by: Vivek Vishal 110674407+vishalvivekm@users.noreply.github.com