All Meshmodel-categories Icons Added #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritiksaxena124 <ritiksaxena124@gmail.com>
Signed-off-by: ritiksaxena124 <ritiksaxena124@gmail.com>
leecalcote
reviewed
Mar 14, 2023
There was a problem hiding this comment.
ui/public/static/img/model-categories/label-green/serverless-label-green.svg is in need of having its linear gradient updated, @ritiksaxena124
Signed-off-by: ritiksaxena124 <ritiksaxena124@gmail.com>
Signed-off-by: ritiksaxena124 <ritiksaxena124@gmail.com>
Chadha93
reviewed
Mar 15, 2023
There was a problem hiding this comment.
@ritiksaxena124 Please also top up this with a new Tools icon
Signed-off-by: Ritik Saxena <ritiksaxena124@gmail.com>
Chadha93
reviewed
Mar 15, 2023
There was a problem hiding this comment.
@ritiksaxena124 Please revert the folder name to green for the green-label as earlier otherwise we have to update the path in extensions again. Also please ensure to test your PR locally with extensions.
Signed-off-by: Abhishek kr <abhimait1909@gmail.com>
Abhishek-kumar09
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Added Icons: (dark, light, white and label versions)
Signed commits