While importing kubeconfig, showback information about K8s context registration #7571
Conversation
…ures Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
|
@MdSahil-oss Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7571 +/- ##
==========================================
- Coverage 16.53% 16.52% -0.01%
==========================================
Files 121 121
Lines 16931 16941 +10
==========================================
Hits 2799 2799
- Misses 13626 13636 +10
Partials 506 506
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
server/handlers/k8sconfig_handler.go
Outdated
| resp := K8sConfigResonseOutput{ | ||
| K8sConfigOutputs: uiMessages, | ||
| } | ||
| json.NewEncoder(w).Encode(resp) |
There was a problem hiding this comment.
Please check for errors while encoding and send response accordingly.
There was a problem hiding this comment.
@MUzairS15 Please review this PR again
|
|
||
| return ctx | ||
| return ctx, msg |
There was a problem hiding this comment.
Please send the contexts name list in response. UI can present the message accordingly.
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
MdSahil-oss
changed the title
|
@MdSahil-oss, signal when feedback has been incorporated and you're ready for review again. |
|
@leecalcote This PR is ready to review :) |
|
@MdSahil-oss goooood, good. Did we ever get this one demo'ed on the Meshery Dev meeting? If not, will you do so in this week's meeting? |
|
Note that a merge conflict has popped up. |
|
@MdSahil-oss Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :) I'm adding this as agenda item. |
Signed-off-by: MdSahil-oss <Mohdssahil1@gmail.com>
Notes for Reviewers
This PR fixes #6331
Signed commits