Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a dropdown to MeshModelComponent to display Component Details #7632

Closed
wants to merge 26 commits into from
Closed

Added a dropdown to MeshModelComponent to display Component Details #7632

wants to merge 26 commits into from

Conversation

UsmanDev09
Copy link
Contributor

@UsmanDev09 UsmanDev09 commented Apr 29, 2023 •
edited

Notes for Reviewers

This PR fixes #7620

How should this be tested?

meshmodel dropdown

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Apr 29, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@github-actions github-actions bot added the component/ui User Interface label Apr 29, 2023
@leecalcote
Copy link
Member

It’s nice to see movement on this, @UsmanDev09.

These folks might have some feedback: @MdSahil-oss @theBeginner86 @Abhishek-kumar09 @meshery/maintainers

@leecalcote leecalcote requested review from acald-creator and a team and removed request for acald-creator April 30, 2023 00:28
@leecalcote leecalcote added the area/models Models, Components, Relationships related changes label Apr 30, 2023
theBeginner86
theBeginner86 reviewed May 1, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, relationships also seems to be getting these dropdown. Would you please look into it?

Screenshot 2023-05-01 at 8 01 33 PM

theBeginner86
theBeginner86 reviewed May 1, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a given instant only one dropdown is clickable. Is that intended?

Users might get confused, if the carrot dropdown isn't disabled. Considering, this is intended.

Screen.Recording.2023-05-01.at.7.57.31.PM.mov

@theBeginner86
Copy link
Member

theBeginner86 commented May 1, 2023 •
edited

hmm, relationships also seems to be getting these dropdown. Would you please look into it?
Screenshot 2023-05-01 at 8 01 33 PM

Fixing above should also fix below issue of multiple request to backend on opening dropdown for relationships.
Screenshot 2023-05-01 at 8 05 05 PM

@harkiratsm
Copy link
Member

It would be nice if a page would be dedicated just to meshmodel details, with an admin only access. // @leecalcote @Abhishek-kumar09

theBeginner86
theBeginner86 reviewed May 1, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @UsmanDev09 🙌 💯

This update was very much needed.

theBeginner86
theBeginner86 previously approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theBeginner86
Copy link
Member

@UsmanDev09

If you may please consider signing-off your last few commits?
https://github.com/meshery/meshery/pull/7632/checks?check_run_id=13150194854

MUzairS15
MUzairS15 reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UsmanDev09 Thanks for creating PR, really some good work here 👏🏻.

Just a small item
Screenshot 2023-05-01 at 10 17 42 PM

The size of Meshery logo and text is not proper, will you also address this and make sure the size is in accordance?

@UsmanDev09 UsmanDev09 requested a review from MUzairS15 May 2, 2023 07:17
@UsmanDev09 UsmanDev09 force-pushed the UsmanDev09-ui-meshmodelsummary-dropdown branch from 0546dff to 47cd84d Compare May 2, 2023 07:33
@github-actions github-actions bot added area/docs Documentation update needed component/mesheryctl CLI for Meshery component/server labels May 2, 2023
@UsmanDev09
Merge branch 'master' into UsmanDev09-ui-meshmodelsummary-dropdown
db0fc85 
Signed-off-by: Muhammad Usman <31584129+UsmanDev09@users.noreply.github.com>
UsmanDev09 and others added 22 commits May 2, 2023 12:32
@UsmanDev09
Subject: Implemented Dropdown to display component details
496ae1f 
Description:
Imported Table Row from Material UI Library and API Endpoint
Added a state variable 'componentDetails'
Added a function to call API endpoint
Added RowExpandable function to 'mui/datatables' library to handle click on cell and display component details in a dropdown'

Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
Changed name to displayName
6c8ca04 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
removed console.log
939bc80 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
Turned off filter
e864213 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
Disabled dropdown when relationships are selected
d7a4051 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
At a given instant, multiple dropdowns are clickable
87d767d 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
Size of meshery logo and text adjusted
3ea3c4e 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
latest discussion data files added
50438b9 
Signed-off-by: Discussions bot <discussions@meshery.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
New Meshmodel components generated
a746f92 
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@Aisuko @UsmanDev09
Increase test coverage for mesheryctl
695fd54 
Signed-off-by: Aisuko <urakiny@gmail.com>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@Revolyssup @UsmanDev09
Add instruction to reinstall Meshery in playground
24ea9ec 
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@Abhishek-kumar09 @UsmanDev09
[Docs] Release Notes for Meshery
33a0432 
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
latest discussion data files added
b998e9e 
Signed-off-by: Discussions bot <discussions@meshery.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
New Meshmodel components generated
3623b6d 
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@UsmanDev09
Adapters Component added
b871e13 
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@shivamganwani @UsmanDev09
fix typo in summary
96e1650 
Signed-off-by: Shivam Ganwani <shivam.ganwani.v@gmail.com>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
latest discussion data files added
dddbc25 
Signed-off-by: Discussions bot <discussions@meshery.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
New Meshmodel components generated
d2433c7 
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@Aisuko @UsmanDev09
Increase testing coverage and fix defer error
f6a9bb3 
Signed-off-by: Aisuko <urakiny@gmail.com>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
latest discussion data files added
5a56ff9 
Signed-off-by: Discussions bot <discussions@meshery.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote @UsmanDev09
New Meshmodel components generated
47cd84d 
Signed-off-by: l5io <ci@layer5.io>
Signed-off-by: UsmanDev09 <usiddique09@gmail.com>
@leecalcote
Merge branch 'master' into UsmanDev09-ui-meshmodelsummary-dropdown
9a9cbe9
@leecalcote
Copy link
Member

@UsmanDev09 will you resync your fork with upstream master?

@l5io
Copy link
Collaborator

l5io commented May 2, 2023

🚀 Preview for commit 9a9cbe9 at: https://64513d8b2f14da0e53b94c55--meshery-docs-preview.netlify.app

@MdSahil-oss
Copy link
Contributor

@UsmanDev09 Great work, Looks good to me, But can we highlight border of the opened table for some seconds? like happens in stack overflow (It would be better if we could do this).

@leecalcote
Copy link
Member

@UsmanDev09 is this PR still valid given #7672 ?

@UsmanDev09
Copy link
Contributor Author

@leecalcote No, I am closing this PR

@UsmanDev09 UsmanDev09 closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

@theBeginner86 theBeginner86 Awaiting requested review from theBeginner86

Assignees
No one assigned
Labels
area/docs Documentation update needed area/models Models, Components, Relationships related changes component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Create a dropdown to show mesh model summary