Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move dark mode under preferences menu #7726

Merged
merged 2 commits into from May 26, 2023

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented May 23, 2023

Notes for Reviewers

This PR fixes #7377
The dark mode section is moved under preferences in general section

darkmode.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 23, 2023
@leecalcote
Copy link
Member

This is great. Please use the same component with label placement for this theme section.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending resizing

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending resizing

Signed-off-by: sudhanshu dasgupta <dasguptashivam23@gmail.com>
@sudhanshutech
Copy link
Member Author

Pending resizing
are you referring to this
image

@leecalcote leecalcote merged commit a2b262a into meshery:master May 26, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]Move the dark mode option under preferences section
2 participants